fix(tpu-v2): provide ethcoin support in tpu kickstart process #2300
Conversation
laruh
force-pushed
the
fix-tpu-v2-wait-for-payment-spend-kickstart
branch
from
d08fa86 to
df7778c
Compare
This reverts commit df7778c.
…swap_kickstart_handler_for_taker in swap_kick_starts func
|
Can you add test coverage for ETH ? Seems like we have one for UTXOs |
I can, but it will be on sepolia and use feature flag |
No problem I guess, better than nothing |
…-for-payment-spend-kickstart
…-for-payment-spend-kickstart
laruh
force-pushed
the
fix-tpu-v2-wait-for-payment-spend-kickstart
branch
from
6c332f2 to
1e10d83
Compare
laruh
force-pushed
the
fix-tpu-v2-wait-for-payment-spend-kickstart
branch
from
1e10d83 to
d48cc25
Compare
…d' into fix-tpu-v2-wait-for-payment-spend-kickstart
|
Added |
| let uuids = block_on(start_swaps(&mut mm_bob, &mut mm_alice, &[(ETH, ETH1)], 1.0, 1.0, 77.)); | ||
| log!("{:?}", uuids); | ||
| let parsed_uuids: Vec<Uuid> = uuids.iter().map(|u| u.parse().unwrap()).collect(); | ||
|
|
||
| for uuid in uuids.iter() { | ||
| log_swap_status_before_stop(&mm_bob, uuid, "Maker"); | ||
| log_swap_status_before_stop(&mm_alice, uuid, "Taker"); | ||
| } |
There was a problem hiding this comment.
nit: uuids is just a single item in a vector. you might want to extract it.
| // Restart Bob and Alice | ||
| bob_conf.conf["dbdir"] = mm_bob.folder.join("DB").to_str().unwrap().into(); | ||
| bob_conf.conf["log"] = mm_bob.folder.join("mm2_dup.log").to_str().unwrap().into(); |
There was a problem hiding this comment.
nit: or you might just use MarketMakerIt::seednode_trade_v2
| alice_conf.conf["dbdir"] = mm_alice.folder.join("DB").to_str().unwrap().into(); | ||
| alice_conf.conf["log"] = mm_alice.folder.join("mm2_dup.log").to_str().unwrap().into(); | ||
| alice_conf.conf["seednodes"] = vec![mm_bob.ip.to_string()].into(); |
There was a problem hiding this comment.
nit: or MarketMakerIt::light_node_trade_v2
There was a problem hiding this comment.
btw, why create a different mm2_dup.log? u could not call mm_dump if u want.
This pr provides EthCoin support in kickstart handler for taker and maker swaps
added
test_v2_eth_eth_kickstart